Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-20 17:57:16 UTC

Oops, not merging, that test is getting stuck. I saw you were talking with lucifer yesterday, now I see the issue.
I'll let you figure that one out :0

We might want to adjust the colors to use the ones defined in the YIM24 file (the "text" colors), with variations, maybe?

I had that in mind, but if we do it the graph does not look good.

The tag counts don't look right to me at all, as they all have crazy number 5 times higher than my actual listen count for the year. Not sure there's anything we can do here though.

@amCap1712 As I can see in the SQL query, instead of merging the genre count from recording, artist and release group, can we have that data separate?

We might want to adjust the colors to use the ones defined in the YIM24 file (the "text" colors), with variations, maybe?

I had that in mind, but if we do it the graph does not look good.

I meant more using the four colors, regardless of the chosen season. So where other graph use the selected season's textColor, this graph would use all 4 textColor from the seasons. I reckon we might still have the same issue of not enough variety between colours, but maybe it works?

This looks good!